test(Auth): resendSignUpCode unit tests #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #935 +/- ##
==========================================
- Coverage 69.75% 69.37% -0.38%
==========================================
Files 811 894 +83
Lines 34258 37165 +2907
==========================================
+ Hits 23895 25785 +1890
- Misses 10363 11380 +1017
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
royjit
approved these changes
Dec 3, 2020
Contributor
royjit
left a comment
royjit
left a comment
There was a problem hiding this comment.
LGTM - with minor comments
| switch result { | ||
| case .success(let authCodeDeliveryDetails): | ||
| guard case .email = authCodeDeliveryDetails.destination else { | ||
| XCTFail("Result should be .done for next step") |
Contributor
There was a problem hiding this comment.
Suggested change
| XCTFail("Result should be .done for next step") | |
| XCTFail("Result should be . email for next step") |
| /// - When: | ||
| /// - I invoke resendSignUpCode with username | ||
| /// - Then: | ||
| /// - I should get a successful result with .email as the destination of AuthCodeDeliveryDetails |
Contributor
There was a problem hiding this comment.
Suggested change
| /// - I should get a successful result with .email as the destination of AuthCodeDeliveryDetails | |
| /// - I should get a failure with validation error |
| XCTFail("Received failure with error \(error)") | ||
| } | ||
| } | ||
| wait(for: [resultExpectation], timeout: 2) |
Contributor
There was a problem hiding this comment.
You can use the timeout value from the base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.