New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose client configuration through api factory #158

Merged
merged 4 commits into from Jun 27, 2016

Conversation

Projects
None yet
4 participants
@fgoncalves
Copy link
Contributor

fgoncalves commented Jun 23, 2016

In our code base we found it very useful to expose the ClientConfiguration through the ApiClientFactory. This let's us for example set the user agent for all our calls since we do a lot of client identification based on this header.

We'd like to propose this change. We didn't break the contract and respected the method chaining previously there. One can set the configuration as such:

new ApiClientFactory()
                .clientConfiguration(clientConfiguration)
                .endpoint("some endpoint");

Thank you

fgoncalves added some commits Jun 20, 2016

Exposing client configuration on the api gatway factory
Signed-off-by: Fred <fgoncalves@babbel.com>
Ensure we always have a client configuration
Signed-off-by: Fred <fgoncalves@babbel.com>
Remove previously added formatting
Signed-off-by: Fred <fgoncalves@babbel.com>
Small formatting issue
Signed-off-by: Fred <fgoncalves@babbel.com>
@AutomatedPlayground

This comment has been minimized.

Copy link

AutomatedPlayground commented Jun 23, 2016

+🅱️

@laurens

This comment has been minimized.

Copy link

laurens commented Jun 27, 2016

+1 thanks!

@fosterzhang

This comment has been minimized.

Copy link
Contributor

fosterzhang commented Jun 27, 2016

Make sense. Thank you.

@fosterzhang fosterzhang merged commit 66e5a23 into aws-amplify:master Jun 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment