-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the React and React Native documentation. Usage and Setup are really confusing. #69
Comments
Thanks for the feedback, and apologies for your frustration. Our We purposefully try to keep the API the same across platforms. This is the reason we combined the Framework support guides for react/react native, and similarly angular and ionic. The only key difference with RN is the We also had migrated the majority of the specifics into new Getting Started guides, specific to framework: For deeper guide for both React and React Native: And specifically each category outlines it's UI components and usage: There is also a starter with a completely custom UI utilizing the base API here: There is also a list maintained by one of our developer advocates with some specific React Native examples here: Specifically around Auth a great custom UI here: Can you let me know which part you are having a hard time with specifically? We are working on a large update to our docs that will move these over to a new repo as well so that we can iterate on them faster without requiring library build/test steps. |
Thank you for the feedback. Very happy to hear the docs are being worked on. In brief this is my status for react native. The good :
The bad :
|
Thanks @angineering this is really good information and I appreciate you taking the time to put it together. I think most of this is pretty clear and straight forward to address. I will try and get some of this addressed in the next major update which is (i'm hoping) to be this week. I'll update this issue with it for review if you are up for taking a look and letting me know if it covers these adequately i'd greatly appreciate it. |
Thank you, I would be happy to have a look. It's really great to hear it's already being addressed! |
I can agree that the documentation of how to implement a custom UI with authenticator needs improvement. As @angineering have I spent multiple days trying to implement a custom signup screen without success. |
@karlmosenbacher @angineering can you take a look at the following update to the authentication guide and let me know if this helps: I haven't exactly split these up completely yet, but provided a high-level overview of all the options available on the |
Thank you for the quick update @mlabieniec . The new definitions of props are super helpful. Great addition! Would you be able to add a note on how to:
Other comments:I thought the federated prop only worked in React and not React Native? Has this changed?
In the section "Using the Authenticator Component Directly":
on this line: "authData - additional data within authState; when the state is signedIn, it will return a user object." could you link to the definition of what a user object is?
In Enabling Federated Identities:
In the Federated Identities section it's in an easy-to-miss line specified that with React Native you have to do federation manually.
Any chance we could have some screenshots of what e.g. the signup screen by default looks like on web and mobile if you use withAuthenticator(app) so people know what to expect? Thank you so much for fixing the documentation!! |
@angineering thank you for the thorough feedback this is very helpful and I think it’s all pretty clear. I am going to review these with the team today and try to incorporate this all into my next push this afternoon. Thanks for taking the time to list all this out much appreciated. |
@mlabieniec thanks for the updated docs! Really appreciated. I have one thought tho regarding the authenticator docs. It says in the docs that when using the authenticator it will give you more customization options for your UI. Does this mean that I can create my own SignUp screen or can I only customize the default SignUp screen? And how can I create my own SignUp screen? Will my customized screen work with the other screens? These are some question that would all be answered if you could give us a complete example in how to implement a custom screen with the authenticator. I know there is one for the withAuthenticator. Before when adding the SignUp screen in the hide property of the Authenticator, the create account text disappeared in the SignIn screen, is it still like that? BR |
@karlmosenbacher thanks for the input. Recently the withAuthenticator has been updated to also provide more customization, so it's not as locked down as before. However, you can't obviously place it where you'd like in your app or position it anywhere in particular is the caveat where you would probably use the Authenticator at this point. Does that make sense? For the using particular parts of the Authenticator, you can customize it to only show particular parts i.e. <Authenticator hideDefault={true}>
<SignIn/>
</Authenticator> Or use the |
@mlabieniec that makes absolutely sense, but Im afraid thats not the issue I am having, and I am trying to go away from using the API and take advantage of Authenticator (or withAuthenticator) as mush as possible. Please correct me if Im wrong now, but I try to use the Authenticator in this way: This would be in the App.js file (not index.js).
and then in my MyCustomSignUp-component
I think I have seen a guide with this implementation but I dont know if its correct or not? |
@karlmosenbacher it should be like: <Authenticator hideDefault={true}>
<SignIn />
<MyCustomSignUp />
</Authenticator> And yes in your signUp component, you should render it or not based on the if (props.onStateChange) props.onStateChange(state, data); |
@powerful23 thanks for clarifying it! |
hi @mlabieniec thank you again for working on this. I was wondering if you would be able to quickly explain how to set up aws amplify to use email instead of username? as in the photo https://aws-amplify.github.io/docs/js/authentication#sign-up . It always sets up with username and makes it unchangeable whenever I do it. Can't wait for the new documentation :) |
Is your feature request related to a problem? Please describe.
It is very frustrating and confusing to try to get started with AWS amplify when building for react native, as the documentation does not make it clear on many accounts what work for react and what works for React Native. A lot of the examples error when trying them in React Native. I have so far spent several days making very little progress.
Describe the solution you'd like
Separate documentation for React and React Native. Even though they are similar languages they are very much not the same.
Describe alternatives you've considered
Scrapping AWS Amplify and using Firebase instead.
Additional context
Particularly full, working examples of custom UI and Authenticators you can try out. https://aws-amplify.github.io/amplify-js/media/authentication_guide.html#create-your-own-ui is not a working example. It should be changed to something you can just copy paste to try out.
The text was updated successfully, but these errors were encountered: