-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[v2] DataStore content re-org for all platforms #1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] DataStore content re-org for all platforms #1462
Conversation
jamesonwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wowser, lots of changes! Hey @drochetti, what is the best way to evaluate the new flow, and the new rendered markdown? Is there way to preview the entire set of changes?
yeah, sorry for the huge PR. The good news is the content is mostly the same, I just removed the duplicated content across all platforms and extracted mostly the code snippets and platforms callout into platform-specific fragments. I fixed the faulty ones, but the flow of the documentation is mostly the same (if anything I simplified a bit, hence the number of removed lines). Regarding the preview, not sure why the Amplify Web Preview is not enabled here, let me check that. |
|
@drochetti - the previews are only enabled on PRs from branches of aws-amplify/docs repo. If you forked the repo into your own repo, the previews aren't enabled :-( |
|
That's too bad, we used forked review in the past by self hosting on GitHub |
|
@drochetti After looking at this, it is indeed difficult to review without having the site rendered. My recommendation is one of the following:
IMO # 1 is the best as it's less back and forth and iterative reviews. We can make @dabit3 optional on the call. Thoughts? |
Yeah, my bad. I was used to make changes using the forked review and didn't realize the web preview didn't work until it was too late =/ We can definitely do # 1. |
Notes:
Major content reorganization of the
Amplify.DataStore. Given the user feedback and issues we've got mainly on the iOS and Android repos, I did a full review of the content when migrating to the new site. Some of the main changes involved:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.