Skip to content

Update subscription example in iOS Getting Started - #2631

Merged
Kilo-Loco merged 2 commits into
aws-amplify:masterfrom
Kilo-Loco:ios/getting-started-subscription-update
Nov 4, 2020
Merged

Update subscription example in iOS Getting Started#2631
Kilo-Loco merged 2 commits into
aws-amplify:masterfrom
Kilo-Loco:ios/getting-started-subscription-update

Conversation

@Kilo-Loco

Copy link
Copy Markdown
Contributor

The example for subscribing to mutation events did not include a clear way to decode and switch logic based on the . This update includes an example of how to accomplish the two, making it clear to the user how to handle an object that was created, updated, or deleted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The example for subscribing to mutation events did not include a clear way to decode and switch logic based on the . This update includes an example of how to accomplish the two, making it clear to the user how to handle a  object that was created, updated, or deleted.
@Kilo-Loco Kilo-Loco added the amplify/ios Mostly related to iOS software. label Nov 3, 2020
@Kilo-Loco
Kilo-Loco requested review from a team and wooj2 November 3, 2020 19:15

@drochetti drochetti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this docs, it's definitely lacking details.

I left one comment regarding the enum instantiation from the raw value, other than that it lgtm!

Comment thread docs/start/getting-started/fragments/ios/add-api.md Outdated

@drochetti drochetti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Kilo-Loco
Kilo-Loco merged commit 5f68c03 into aws-amplify:master Nov 4, 2020
@Kilo-Loco
Kilo-Loco deleted the ios/getting-started-subscription-update branch November 4, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amplify/ios Mostly related to iOS software.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants