New STYLEGUIDE! #4809
Merged
New STYLEGUIDE! #4809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the style guide we have started using for new content internally. When referring to the styleguide in PR reviews, call out individual rules using their numbers. Cheers!
palpatim
reviewed
Nov 10, 2022
renebrandel
reviewed
Nov 10, 2022
renebrandel
reviewed
Nov 10, 2022
Co-authored-by: Tim Schmelter <schmelte@amazon.com>
Co-authored-by: Tim Schmelter <schmelte@amazon.com>
Co-authored-by: Tim Schmelter <schmelte@amazon.com>
Co-authored-by: Tim Schmelter <schmelte@amazon.com>
Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>
Co-authored-by: Rene Brandel <4989523+renebrandel@users.noreply.github.com>
katieklein
previously approved these changes
Nov 17, 2022
cwomack
reviewed
Nov 17, 2022
cwomack
reviewed
Nov 17, 2022
palpatim
reviewed
Nov 17, 2022
cshfang
reviewed
Nov 18, 2022
|
|
||
| * Key names are enclosed in `"` | ||
| * Values are between `"` instead of `'` | ||
| * No comments |
Contributor
There was a problem hiding this comment.
Can/should we include recommendations for adding context/descriptions to specific properties in lieu of inline comments?
Contributor
Author
There was a problem hiding this comment.
If you think so, please suggest an edit.
Co-authored-by: Tim Schmelter <schmelte@amazon.com>
Co-authored-by: Tim Schmelter <schmelte@amazon.com>
Co-authored-by: Tim Schmelter <schmelte@amazon.com>
katieklein
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the style guide we have started using for new content internally. When referring to the styleguide in PR reviews, call out individual rules using their numbers. Cheers!
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.