Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging resource type coverage #228

Open
PatMyron opened this issue Oct 18, 2019 · 3 comments
Open

Tagging resource type coverage #228

PatMyron opened this issue Oct 18, 2019 · 3 comments

Comments

@PatMyron
Copy link
Member

@PatMyron PatMyron commented Oct 18, 2019

Should be able to create and update tags at the stack-level and resource-level for all resource types that support tagging natively without unnecessary resource replacement

Working on generating a list of resource types that support resource-level tagging but not stack-level tagging

#4
#7
#19
#28
#29
#64
#69
#74
#77
#84
#95
#96
#117
#133
#155
#176
#178
#184
#193
#194
#195
#196
#200
#202
#203
#205
#219
#231
#236
#238
#248
#277
#306
#309
#328
#340
#350
#354
#358

@andyjgordon

This comment has been minimized.

Copy link

@andyjgordon andyjgordon commented Jan 29, 2020

Hi @PatMyron, I don't see AWS::Glue::Crawler in the above list, which I know suffers the same issue (stack-level tags dont get applied). Also suspect AWS::Glue::Workflow and AWS::Glue::Trigger may have the same, but would need to test. Do you want me to create an issue for these?

@benkehoe

This comment has been minimized.

Copy link

@benkehoe benkehoe commented Jan 29, 2020

As support is added for CloudFormation to add its automatic tags to more resource types, there should be a way to get those tags added to existing resources in a stack without providing a changed template.

@ikben

This comment has been minimized.

Copy link

@ikben ikben commented Jan 29, 2020

As support is added for CloudFormation to add its automatic tags to more resource types, there should be a way to get those tags added to existing resources in a stack without providing a changed template.

But it should be aware of resources that require some interruption or replacement when adding them. Eg. EIP or ElasticBeanstalk Environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
coverage-roadmap
  
We're working on it
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.