From 670c6cf57c73e42ba96f58de65dd4b0fcab162c1 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 31 Jan 2020 18:26:03 +0000 Subject: [PATCH 1/5] Bump checkstyle from 8.18 to 8.29 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.18 to 8.29. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](https://github.com/checkstyle/checkstyle/compare/checkstyle-8.18...checkstyle-8.29) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0ca364e1..87a8d3e2 100644 --- a/pom.xml +++ b/pom.xml @@ -38,7 +38,7 @@ UTF-8 UTF-8 2.10.49 - 8.18 + 8.29 2.6 2.10.1 3.1.0 From db1c2f552f445d6c78c51567925f72deefef4fed Mon Sep 17 00:00:00 2001 From: Toby Fleming Date: Tue, 11 Feb 2020 15:05:40 -0800 Subject: [PATCH 2/5] CheckStyle: move LineLengthCheck from TreeWalker to Checker --- .../com/amazonaws/cloudformation/checkstyle.xml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml b/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml index b2ca4cd2..14ab2556 100644 --- a/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml +++ b/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml @@ -31,6 +31,12 @@ + + + + + + - - - - - - From 8844a41a9ea53090ad85e72561750d504f4661e6 Mon Sep 17 00:00:00 2001 From: Toby Fleming Date: Tue, 11 Feb 2020 15:06:42 -0800 Subject: [PATCH 3/5] Remove com.github.aws.aws-sdk-java-v2:build-tools until they have upgraded CheckStyle --- pom.xml | 5 ----- .../resources/com/amazonaws/cloudformation/checkstyle.xml | 6 ------ 2 files changed, 11 deletions(-) diff --git a/pom.xml b/pom.xml index 87a8d3e2..ac321b36 100644 --- a/pom.xml +++ b/pom.xml @@ -342,11 +342,6 @@ checkstyle ${checkstyle.version} - - com.github.aws.aws-sdk-java-v2 - build-tools - 2.10.18 - diff --git a/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml b/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml index 14ab2556..84736d4c 100644 --- a/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml +++ b/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml @@ -353,16 +353,10 @@ - - - - - - From e9e0f9ea7798f81698a13b6eeaa09c7e7bcd2775 Mon Sep 17 00:00:00 2001 From: Toby Fleming Date: Tue, 11 Feb 2020 15:11:56 -0800 Subject: [PATCH 4/5] Workaround for separateLineBetweenGroups being broken in CheckStyle --- pom.xml | 10 +++++----- .../com/amazonaws/cloudformation/checkstyle.xml | 3 ++- .../cloudformation/eclipse-java-formatter.xml | 2 +- .../amazonaws/cloudformation/intellij-codestyle.xml | 1 - 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/pom.xml b/pom.xml index ac321b36..8e282af9 100644 --- a/pom.xml +++ b/pom.xml @@ -211,7 +211,6 @@ - jitpack.io https://jitpack.io @@ -226,6 +225,11 @@ ${spotless.version} + + + com,java,javax,org,software + + ${basedir}/src/main/resources/com/amazonaws/cloudformation/eclipse-java-formatter.xml @@ -234,10 +238,6 @@ licenseHeader - - - com,java,javax,org,software - diff --git a/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml b/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml index 84736d4c..a16f0f9d 100644 --- a/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml +++ b/src/main/resources/com/amazonaws/cloudformation/checkstyle.xml @@ -279,7 +279,8 @@ - + + diff --git a/src/main/resources/com/amazonaws/cloudformation/eclipse-java-formatter.xml b/src/main/resources/com/amazonaws/cloudformation/eclipse-java-formatter.xml index 3320a451..a8ace07d 100644 --- a/src/main/resources/com/amazonaws/cloudformation/eclipse-java-formatter.xml +++ b/src/main/resources/com/amazonaws/cloudformation/eclipse-java-formatter.xml @@ -307,7 +307,7 @@ - + diff --git a/src/main/resources/com/amazonaws/cloudformation/intellij-codestyle.xml b/src/main/resources/com/amazonaws/cloudformation/intellij-codestyle.xml index 4c41185a..cfc533c0 100644 --- a/src/main/resources/com/amazonaws/cloudformation/intellij-codestyle.xml +++ b/src/main/resources/com/amazonaws/cloudformation/intellij-codestyle.xml @@ -23,7 +23,6 @@