Skip to content

Changed Lib name and some settings. Prepare for library release #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Changed Lib name and some settings. Prepare for library release #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61ae234
Changed Lib name and some settings. Prepare for release
ammokhov Apr 8, 2021
1175bbf
reverted codegen
ammokhov Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cfn-rpdk",
"version": "0.5.0",
"name": "cloudformation-cli-typescript-lib",
"version": "1.0.0",
"description": "The CloudFormation Resource Provider Development Kit (RPDK) allows you to author your own resource providers that can be used by CloudFormation. This plugin library helps to provide runtime bindings for the execution of your providers by CloudFormation.",
"private": false,
"main": "dist/index.js",
Expand All @@ -27,14 +27,14 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/eduardomourar/cloudformation-cli-typescript-plugin.git"
"url": "git+https://github.com/aws-cloudformation/cloudformation-cli-typescript-plugin.git"
},
"author": "eduardomourar",
"license": "MIT",
"author": "Amazon Web Services",
"license": "Apache License 2.0",
"bugs": {
"url": "https://github.com/eduardomourar/cloudformation-cli-typescript-plugin/issues"
"url": "https://github.com/aws-cloudformation/cloudformation-cli-typescript-plugin/issues"
},
"homepage": "https://github.com/eduardomourar/cloudformation-cli-typescript-plugin#readme",
"homepage": "https://github.com/aws-cloudformation/cloudformation-cli-typescript-plugin#readme",
"dependencies": {
"@org-formation/tombok": "^0.0.1",
"autobind-decorator": "^2.4.0",
Expand Down
18 changes: 11 additions & 7 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,27 +28,31 @@ def find_version(*file_paths):
description=__doc__,
long_description=read("README.md"),
long_description_content_type="text/markdown",
author="eduardomourar",
author_email="eduardomourar@users.noreply.github.com",
url="https://github.com/eduardomourar/cloudformation-cli-typescript-plugin",
author="Amazon Web Services",
author_email="aws-cloudformation-developers@amazon.com",
url="https://github.com/aws-cloudformation/cloudformation-cli-typescript-plugin",
packages=["rpdk.typescript"],
package_dir={"": "python"},
# package_data -> use MANIFEST.in instead
include_package_data=True,
zip_safe=True,
python_requires=">=3.6",
install_requires=["cloudformation-cli>=0.1.14", "zipfile38>=0.0.3,<0.2"],
install_requires=[
"cloudformation-cli>=0.1.14",
"docker>=3.7,<5",
Copy link
Contributor

@PatMyron PatMyron Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for pinning docker versions? (since docker is already an indirect dependency through cloudformation-cli)

Copy link
Contributor

@eduardomourar eduardomourar Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy code. It was added when cfn-CLI didn't have docker. And because we have a implicit dependency on SAM CLI which does require docker: https://github.com/aws-cloudformation/cloudformation-cli-typescript-plugin/blob/master/python/rpdk/typescript/codegen.py

"zipfile38>=0.0.3,<0.2",
],
entry_points={
"rpdk.v1.languages": [
"typescript = rpdk.typescript.codegen:TypescriptLanguagePlugin",
]
},
license="MIT",
license="Apache License 2.0",
classifiers=[
"Development Status :: 2 - Pre-Alpha",
"Development Status :: 5 - Production/Stable",
"Environment :: Console",
"Intended Audience :: Developers",
"License :: OSI Approved :: MIT/X Consortium License",
"License :: OSI Approved :: Apache Software License",
"Natural Language :: English",
"Topic :: Software Development :: Build Tools",
"Topic :: Software Development :: Code Generators",
Expand Down