Skip to content

Conversation

@anshikg
Copy link

@anshikg anshikg commented May 18, 2021

@anshikg anshikg requested a review from omkhegde May 18, 2021 17:42
"version": "4.17.20",
"resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.20.tgz",
"version": "4.17.21",
"resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.21 .tgz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space.

"resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.20.tgz",
"version": "4.17.21",
"resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.21 .tgz",
"integrity": "sha512-PlhdFcillOINfeV7Ni6oF1TAEayyZBoZ8bcshTHqOYJYlrqzRK5hagpagky5o4HfCzzd1TRkXPMFq6cKk9rGmA==",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hash needs to change for lockfiles as well
http://github.com/aws-cloudformation/cloudformation-cli-typescript-plugin/pull/52 should already cover this, but tests need to be fixed

@PatMyron PatMyron closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants