removing duplicate module validation caught by cfn-lint

[PatMyron]

#634
#644

left module-specific validation like restrictions on exports, macros/transforms, and nested stacks

[MalikAtalla-AWS]

Validations like this have been added to avoid parsing errors that are impossible to understand by the user. I'm not sure if we're regressing on the user experience here.

[PatMyron]

cfn-lint will throw E1001 Missing top level template section Resources for this validation

[miparnisari]

@PatMyron For all the validations that you removed in this PR can you show us what it looks like right now and what it will look like after? Wanna make sure that the error messages in cfn-lint are on par with the ones in the CLI

[MalikAtalla-AWS]

My concern is that cfn lint is executed after these validations and that some validations require others. For example this line checks that the Resources section exists, but there are other validations further down which assume that this validation has already happened. So, I suspect that in this case the user would only see some kind of null pointer exception instead of a useful message. (which is why Maria asked for these cases to be tested)

[miparnisari]

The fragments folder cannot have more than 1 json or yaml file. Can we add this validation? Otherwise it'll fail at runtime during registration

[MalikAtalla-AWS]

That validation should already exist, Maria. I had added that a while ago.

[miparnisari]

That validation should already exist, Maria. I had added that a while ago.

I was able to submit a module today with two files inside fragments: s3.json and blabla.json.old

I had an old version of the CFN CLI

[mircealam]

@MalikAtalla-AWS @PatMyron does this change still apply and/or what rework is needed here?

[MalikAtalla-AWS]

My comments are addressed, but the build is failing @mircealam

[PatMyron]

My comments are addressed, but the build is failing @mircealam

looks like that test was removed in #1028 already