Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 29, 2025

Update to ACK runtime v0.56.0, code-generator v0.56.0



NOTE:
This PR increments the release version of service controller from v1.1.2 to v1.2.0

Once this PR is merged, release v1.2.0 will be automatically created for acm-controller

Please close this PR, if you do not want the new patch release for acm-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building acm-controller ====
Copying common custom resource definitions into acm
Building Kubernetes API objects for acm
Generating deepcopy code for acm
Generating custom resource definitions for acm
Building service controller for acm
Running GO mod tidy
Generating RBAC manifests for acm
Running gofmt against generated code for acm
Updating additional GitHub repository maintenance files
==== building acm-controller release artifacts ====
Building release artifacts for acm-v1.2.0
Generating common custom resource definitions
Generating custom resource definitions for acm
Generating RBAC manifests for acm

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 29, 2025
@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 November 29, 2025 03:40
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
acm-verify-code-gen ee60c73 link false /test acm-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI about 13 hours ago

To fix the problem, add a permissions block specifying the least privilege needed. Since the workflow calls a reusable workflow and does not declare any local steps requiring specific privileges, it is good practice to add permissions at the workflow (root) or job specification level with all permissions set to read by default, unless the job specifically requires write access to any resources. The recommended minimal fix is placing a permissions: block at the root level (top of the file), setting contents: read. This ensures the workflow will run with only read access to repository contents and avoids unnecessary privilege elevation. If the job or called reusable workflow requires more permissions, adjust the block accordingly.

Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -1,5 +1,8 @@
 name: Hydrate Go Proxy
 
+permissions:
+  contents: read
+
 on:
   push:
     branches:
EOF
@@ -1,5 +1,8 @@
name: Hydrate Go Proxy

permissions:
contents: read

on:
push:
branches:
Copilot is powered by AI and may make mistakes. Always verify output.
@a-hilaly
Copy link
Member

/retest

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 29, 2025
@ack-prow ack-prow bot merged commit 2827c44 into main Nov 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants