-
Notifications
You must be signed in to change notification settings - Fork 18
Update to ACK runtime v0.56.0, code-generator v0.56.0
#81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 13 hours ago
To fix the problem, add a permissions block specifying the least privilege needed. Since the workflow calls a reusable workflow and does not declare any local steps requiring specific privileges, it is good practice to add permissions at the workflow (root) or job specification level with all permissions set to read by default, unless the job specifically requires write access to any resources. The recommended minimal fix is placing a permissions: block at the root level (top of the file), setting contents: read. This ensures the workflow will run with only read access to repository contents and avoids unnecessary privilege elevation. If the job or called reusable workflow requires more permissions, adjust the block accordingly.
-
Copy modified lines R3-R5
| @@ -1,5 +1,8 @@ | ||
| name: Hydrate Go Proxy | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: | ||
| branches: |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update to ACK runtime
v0.56.0, code-generatorv0.56.0v0.56.0release notesv0.56.0release notesNOTE:
This PR increments the release version of service controller from
v1.1.2tov1.2.0Once this PR is merged, release
v1.2.0will be automatically created foracm-controllerPlease close this PR, if you do not want the new patch release for
acm-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.