[Do-not-merge] Sample Changes for Infinite Requeue #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaijal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-bot
pushed a commit
to aws-controllers-k8s/runtime
that referenced
this pull request
Jun 24, 2021
…requeue (Issue #826) (#23) This PR is one of two to implement [Issue #826](aws-controllers-k8s/community#826) [Link to the code-generator PR ](aws-controllers-k8s/code-generator#95) ### Testing I tested the change by enabling it for applicationAutoscaling (ScalableTarget) - [you can check the generated code on this branch just for reference. ](aws-controllers-k8s/applicationautoscaling-controller#21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only for code-review reference on how to use infinite requeue and the generated-code. Issue #826
Link to the runtime PR
Link to the code-generator PR
Testing
I tested the change by enabling it for applicationAutoscaling (ScalableTarget), check out the generated code in this PR for reference.