Skip to content

Reconcillation issue in s3 controller #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mandeepgoyat opened this issue May 10, 2022 · 1 comment
Closed

Reconcillation issue in s3 controller #1288

mandeepgoyat opened this issue May 10, 2022 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mandeepgoyat
Copy link

mandeepgoyat commented May 10, 2022

Describe the bug
I noticed that reconciliation feature not working continuously in s3 controller(v0.1.0)
I am expecting that once s3 controller installed then it should detect the drift continuously and restore the resource back to its original state.
Reconciliation happens but only when I delete the controller's pod. Looks like not working continuously like Crossplane

Steps to reproduce

  1. Installed the s3 controller via helm
  2. Create IAM role for service account
  3. Create s3 resource via manifest file
  4. s3 bucket created successfully
  5. If i delete the s3 bucket manually(via AWS console)
  6. s3 bucket not created automatically

Expected outcome

  1. S3 controller should detect the drift continuously and re create the s3 bucket automatically .

Environment

  • Kubernetes version --1.23
  • Using EKS (yes/no), ---Yes, version is 1.22
  • AWS service targeted --S3
@mandeepgoyat mandeepgoyat added the kind/bug Categorizes issue or PR as related to a bug. label May 10, 2022
@RedbackThomson
Copy link
Contributor

Hey Mandeep.
We have common logic in all of the ACK controllers that when the resource reaches its desired state, it will pause reconciliation for a while. It would be CPU intensive to continuously check for drift at a relatively short interval, so we leave that to the K8s API server default requeue time, which I think is 8 hours. I understand that waiting 8 hours for drift detection is probably too long to rely on. From what I can see, Crossplane also defaults back to the API server for their resources (see code here). Perhaps you could tell me what experience you've had with drift detection, and what an appropriate amount of time would be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants