Skip to content

Conversation

@kirananil007
Copy link
Contributor

Description of changes:

Updating the README for AWS ACK Elasticache with added support for resources such as serverless cache, serverless cache snapshot and cache cluster.

Please see the image snippet and the ack documentation link.
https://aws-controllers-k8s.github.io/community/reference/elasticache/v1alpha1/cachecluster/
ACK_Elasticache_Resources

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks!

@ack-prow ack-prow bot requested review from a-hilaly and knottnt October 22, 2025 03:31
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 22, 2025
@ack-prow
Copy link

ack-prow bot commented Oct 22, 2025

Hi @kirananil007. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kirananil007
Copy link
Contributor Author

/assign @a-hilaly

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kirananil007 !
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@ack-prow
Copy link

ack-prow bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, kirananil007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Oct 22, 2025
@a-hilaly a-hilaly merged commit 9b34ac5 into aws-controllers-k8s:main Oct 22, 2025
0 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants