-
Notifications
You must be signed in to change notification settings - Fork 3
Update to ACK runtime v0.56.0, code-generator v0.56.0
#14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
To fix this problem, we need to set the permissions key in the workflow file (.github/workflows/postsubmit.yaml) at the top level or for the call-hydrate-go-proxy job. The explicit permissions should be set as restrictive as possible, ideally starting with contents: read unless additional permissions are necessary for this workflow. Since the workflow delegates logic to a reusable workflow, and unless we have documentation for that workflow, the best option is to start with minimal permissions (contents: read). If more permissions are needed, they can be added later.
The change involves inserting a permissions: block at the top level of .github/workflows/postsubmit.yaml, just below the name: key and above the on: block.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update to ACK runtime
v0.56.0, code-generatorv0.56.0v0.56.0release notesv0.56.0release notesNOTE:
This PR increments the release version of service controller from
v0.2.2tov0.3.0Once this PR is merged, release
v0.3.0will be automatically created forglue-controllerPlease close this PR, if you do not want the new patch release for
glue-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.