From ff5f9409ab6f03a9727d2c4f057b56d0e1113cfe Mon Sep 17 00:00:00 2001 From: michaelhtm <98621731+michaelhtm@users.noreply.github.com> Date: Sun, 23 Nov 2025 18:07:10 -0800 Subject: [PATCH] chore: requeue immidiately after creating role Currently, after a role is created, we set the synced condition to false, casuing the controller to requeue the resource and proccess any updates in 30 seconds (default requeue on non synced resource) This is not an ideal use case for users who have thousands of resources, and don't want to wait long for their resources to be processed/ready. --- pkg/resource/role/sdk.go | 2 +- templates/hooks/role/sdk_create_post_set_output.go.tpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/resource/role/sdk.go b/pkg/resource/role/sdk.go index c2ac7c9..4988da0 100644 --- a/pkg/resource/role/sdk.go +++ b/pkg/resource/role/sdk.go @@ -324,7 +324,7 @@ func (rm *resourceManager) sdkCreate( ko.Spec.AssumeRolePolicyDocument = &doc } } - ackcondition.SetSynced(&resource{ko}, corev1.ConditionFalse, nil, nil) + return &resource{ko}, ackrequeue.Needed(fmt.Errorf("role created, requeuing to trigger updates")) return &resource{ko}, nil } diff --git a/templates/hooks/role/sdk_create_post_set_output.go.tpl b/templates/hooks/role/sdk_create_post_set_output.go.tpl index 08610d1..8f24fff 100644 --- a/templates/hooks/role/sdk_create_post_set_output.go.tpl +++ b/templates/hooks/role/sdk_create_post_set_output.go.tpl @@ -5,4 +5,4 @@ ko.Spec.AssumeRolePolicyDocument = &doc } } - ackcondition.SetSynced(&resource{ko}, corev1.ConditionFalse, nil, nil) + return &resource{ko}, ackrequeue.Needed(fmt.Errorf("role created, requeuing to trigger updates"))