-
Notifications
You must be signed in to change notification settings - Fork 15
Update to ACK runtime v0.56.0, code-generator v0.56.0
#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
To fix the issue, add an explicit permissions block to the workflow. Because the workflow calls a reusable workflow as its only job, the minimal and safest fix is to set a root-level permissions: block that restricts the GITHUB_TOKEN to the least privilege required. If you do not know the specific permissions required, you should start with contents: read (the most basic permission often needed to check out code or read repository contents); you can then adjust if more permissions are required. The explicit permissions: block should be inserted after the name: declaration and before jobs:, so it applies to all jobs by default. No imports or definitions are necessary in this YAML file.
-
Copy modified lines R3-R5
| @@ -1,5 +1,8 @@ | ||
| name: Hydrate Go Proxy | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: | ||
| branches: |
a-hilaly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Update to ACK runtime
v0.56.0, code-generatorv0.56.0v0.56.0release notesv0.56.0release notesNOTE:
This PR increments the release version of service controller from
v1.1.3tov1.2.0Once this PR is merged, release
v1.2.0will be automatically created formq-controllerPlease close this PR, if you do not want the new patch release for
mq-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.