-
Notifications
You must be signed in to change notification settings - Fork 13
Update to ACK runtime v0.56.0, code-generator v0.56.0
#61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
The best way to fix the problem is to set an explicit permissions block at the workflow or job level. Since the workflow only defines a single job that calls a reusable workflow, setting permissions at the workflow root is sufficient and ensures all jobs inherit these permissions (unless overridden). The recommended minimal starting point is permissions: {} at the top level, which denies all by default; you can then increase permissions as needed. However, the appropriate permissions depend on the requirements of the reusable workflow being called. If unsure, start with permissions: read-all (which is less privileged than the old default), or preferably, an empty map ({}) for no permissions.
For this fix, add the following to the workflow after name: Hydrate Go Proxy and before on::
permissions: {}No imports, methods, or additional definitions are required; this is a YAML workflow modification only.
-
Copy modified line R2
| @@ -1,4 +1,5 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: {} | ||
|
|
||
| on: | ||
| push: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Update to ACK runtime
v0.56.0, code-generatorv0.56.0v0.56.0release notesv0.56.0release notesNOTE:
This PR increments the release version of service controller from
v1.1.2tov1.2.0Once this PR is merged, release
v1.2.0will be automatically created fornetworkfirewall-controllerPlease close this PR, if you do not want the new patch release for
networkfirewall-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.