Skip to content

Conversation

@tbarizien
Copy link

Issue:

When only using AmazonRDSFullAccess and setting a DBInstance spec.manageMasterUserPassword to true, the controller would fail on DBInstanceCreate because of insufficient permissions (first to use KMS keys then to create passwords) .

This allows the controller to create and manage secrets in secrets manager.

Description of changes:

Adds a recommended-inline-policy file containing the necessary policy for the RDS controller to manage secrets in the AWS SecretStore.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

When only using AmazonRDSFullAccess and setting a DBInstance `spec.manageMasterUserPassword` to true, the controller would fail on DBInstanceCreate because of insufficient permissions (first to use KMS keys then to create passwords) .

This allows the controller to create and manage secrets in secrets manager.
@ack-prow
Copy link

ack-prow bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tbarizien
Once this PR has been reviewed and has the lgtm label, please assign rushmash91 for approval by writing /assign @rushmash91 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested review from knottnt and michaelhtm November 13, 2025 13:55
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 13, 2025

Hi @tbarizien. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant