Add inline policy recommendation for secret management #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When only using AmazonRDSFullAccess and setting a DBInstance
spec.manageMasterUserPasswordto true, the controller would fail on DBInstanceCreate because of insufficient permissions (first to use KMS keys then to create passwords) .This allows the controller to create and manage secrets in secrets manager.
Description of changes:
Adds a recommended-inline-policy file containing the necessary policy for the RDS controller to manage secrets in the AWS SecretStore.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.