Skip to content

fix for #866 - nil Interface check during delete #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2021
Merged

fix for #866 - nil Interface check during delete #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/runtime/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ package runtime
import (
"context"
"time"

"github.com/go-logr/logr"
"github.com/pkg/errors"
corev1 "k8s.io/api/core/v1"
Expand All @@ -34,6 +34,7 @@ import (
ackrtcache "github.com/aws-controllers-k8s/runtime/pkg/runtime/cache"
ackrtlog "github.com/aws-controllers-k8s/runtime/pkg/runtime/log"
acktypes "github.com/aws-controllers-k8s/runtime/pkg/types"
ackcompare "github.com/aws-controllers-k8s/runtime/pkg/compare"
)

// reconciler describes a generic reconciler within ACK.
Expand Down Expand Up @@ -361,7 +362,7 @@ func (r *resourceReconciler) cleanup(
rlog.Enter("rm.Delete")
latest, err := rm.Delete(ctx, observed)
rlog.Exit("rm.Delete", err)
if latest != nil {
if ackcompare.IsNotNil(latest) {
// The Delete operation is likely asynchronous and has likely set a Status
// field on the returned CR to something like `deleting`. Here, we patchResource()
// in order to save these Status field modifications.
Expand Down