From ab912b59fccea2480ef925be2e9051bf5623eea8 Mon Sep 17 00:00:00 2001 From: Troy Lindsay Date: Fri, 15 Apr 2022 11:16:18 -0500 Subject: [PATCH 1/2] Reverting the tags output description change * The "list of" portion of the output description is common in Terraform and communicates that the dev should expect a list rather than an singular object when using this output as an input for another resource or data source. --- examples/basic/outputs.tf | 2 +- outputs.tf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/basic/outputs.tf b/examples/basic/outputs.tf index 61c9a2c..3a193e7 100644 --- a/examples/basic/outputs.tf +++ b/examples/basic/outputs.tf @@ -4,6 +4,6 @@ output "tag_category" { } output "tags" { - description = "The vSphere tags." + description = "The list of vSphere tags." value = module.vsphere_tags.tags } diff --git a/outputs.tf b/outputs.tf index 573c90b..3c366a9 100644 --- a/outputs.tf +++ b/outputs.tf @@ -4,6 +4,6 @@ output "tag_category" { } output "tags" { - description = "The vSphere tags." + description = "The list of vSphere tags." value = (var.create_tags) ? vsphere_tag.tags : data.vsphere_tag.tags } From 4af633d10817cb6282e346e2adea7e2178e51d9a Mon Sep 17 00:00:00 2001 From: Troy Lindsay Date: Fri, 15 Apr 2022 11:18:50 -0500 Subject: [PATCH 2/2] Update generated readme --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 97172b4..0d3e0d6 100644 --- a/README.md +++ b/README.md @@ -1,10 +1,10 @@ # vSphere Tags Terraform Module -Terraform module that either creates or imports a list of [tags][tags] grouped in a [tag category][category] in your [VMware Cloud on AWS][vmconaws] or [VMware vSphere][vsphere] on‑premises environment for labeling your inventory objects with metadata to make it easier to sort and search for these objects. +This Terraform module either creates or imports a list of [tags][tags] grouped in a [tag category][category] in your [VMware Cloud on AWS][vmconaws] or [VMware vSphere][vsphere] on‑premises environment. You use these tags to label your inventory objects with metadata to make it easier to sort and search for these objects. -Of note, tags and categories can span multiple [vCenter Server][vsphere] instances. -When you use [Hybrid Linked Mode][hybrid], tags and tag categories are maintained across your linked domain, which means the on‑premises and VMware Cloud on AWS software‑defined data centers (SDDCs) share tags and tag attributes. +Tags and categories can span multiple [vCenter Server][vsphere] instances. +When you use [Hybrid Linked Mode][hybrid], tags and tag categories are maintained across your linked domain. So in this mode, the on‑premises and VMware Cloud on AWS software‑defined data centers (SDDCs) share tags and tag attributes. If multiple on‑premises vCenter Server instances are configured to use [Enhanced Linked Mode][enhanced], tags and categories are replicated across the vCenter Server instances. ## Usage