Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #881

Merged
merged 1 commit into from Feb 9, 2022
Merged

Fix typos #881

merged 1 commit into from Feb 9, 2022

Conversation

kzys
Copy link
Contributor

@kzys kzys commented Jan 12, 2022

  • Amazon Linux 2 is not "AWS Linux"
  • We shouldn't put AWS before other brands such as Debian.

Signed-off-by: Kazuyoshi Kato katokazu@amazon.com

Description:

Fixed some typos around brand names.

Link to tracking Issue:

NA

Testing:

NA

Documentation:

NA

@kzys
Fix typos
f395f32 
- Amazon Linux 2 is not "AWS Linux"
- We shouldn't put AWS before other brands such as Debian.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@kzys kzys requested a review from a team as a code owner January 12, 2022 21:47
khanhntd
khanhntd approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@khanhntd khanhntd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the typo. IMO, we should specify what Cloud Platform are being used for Amazon Linux since Amazon Linux is only supported on AWS. For GCP, I heard GCP Migration has the support to migrate from Amazon Linux but that is not what our customer's intention. For Azure it does not support that OS.

@kzys
Copy link
Contributor Author

kzys commented Jan 12, 2022 •
edited

How about using "AWS EC2 (OS NAME)"? Also how about changing "AWSOTelCollector Beta" to "AWSOTelCollector"?

@khanhntd
Copy link
Contributor

How about using "AWS EC2 (OS NAME)"? Also how about changing "AWSOTelCollector Beta" to "AWSOTelCollector"?

Totally agree with both of these changes. For the latter changes, would even more agree since the s3 binaries/ artifact links in these OS Doc are release links.

@bryan-aguilar bryan-aguilar merged commit f01687d into aws-observability:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhntd khanhntd khanhntd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kzys @khanhntd @bryan-aguilar