chore(metrics): deprecate withMetricLogger in favor of withMetricsLogger #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MetricsUtils.withMetricsLogger closes aws-powertools#1059
jeromevdl
suggested changes
Feb 21, 2023
Contributor
jeromevdl
left a comment
jeromevdl
left a comment
There was a problem hiding this comment.
Please fix the infinite loop.
powertools-metrics/src/main/java/software/amazon/lambda/powertools/metrics/MetricsUtils.java
Outdated
Show resolved
Hide resolved
…ools/metrics/MetricsUtils.java Co-authored-by: Jérôme Van Der Linden <117538+jeromevdl@users.noreply.github.com>
kozub
reviewed
Feb 21, 2023
powertools-metrics/src/main/java/software/amazon/lambda/powertools/metrics/MetricsUtils.java
Show resolved
Hide resolved
jeromevdl
reviewed
Feb 21, 2023
powertools-metrics/src/main/java/software/amazon/lambda/powertools/metrics/MetricsUtils.java
Show resolved
Hide resolved
kozub
previously approved these changes
Feb 21, 2023
jeromevdl
reviewed
Feb 21, 2023
| .withMessage("Null dimension set not allowed"); | ||
| } | ||
|
|
||
| private void testWithNewLogger(Consumer<Consumer<MetricsLogger>> methodToTest) { |
Contributor
There was a problem hiding this comment.
strange to name it NewLogger when you use it with the deprecated one...
Suggested change
| private void testWithNewLogger(Consumer<Consumer<MetricsLogger>> methodToTest) { | |
| private void testLogger(Consumer<Consumer<MetricsLogger>> loggerToTest) { |
Contributor
Author
There was a problem hiding this comment.
New was as opposed to the default MetricsUtils.metricsLogger() and MetricsUtils.withMetric(s)Logger essentially providing new ones. However, happy to call it testLogger instead to avoid any confusion
jeromevdl
reviewed
Feb 21, 2023
...tools-metrics/src/test/java/software/amazon/lambda/powertools/metrics/MetricsLoggerTest.java
Show resolved
Hide resolved
Contributor
Author
|
Any further things I might have missed? |
jeromevdl
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: #1059
Description of changes:
MetricsUtils.withMetricLoggerMetricsUtils.withMetricsLoggerChecklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.