generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 180
Closed
Labels
completedThis item is complete and has been merged/shippedThis item is complete and has been merged/shippedidempotencyThis item relates to the Idempotency UtilityThis item relates to the Idempotency UtilityinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)testsPRs that add or change testsPRs that add or change tests
Description
Summary
The unit tests for the makeIdempotent function wrapper and the makeHandlerIdempotent Middy.js middleware are very similar except for some lines.
According to SonarCloud, the two test files have 68% of duplication. We should work to reduce this to a minimum.
Why is this needed?
So that we can drop redundant code and reduce maintenance burden and cognitive load for maintainers and contributors.
Which area does this relate to?
Tests
Solution
No response
Acknowledgment
- This request meets Powertools for AWS Lambda (TypeScript) Tenets
- Should this be considered in other Powertools for AWS Lambda languages? i.e. Python, Java, and .NET
Future readers
Please react with 👍 and your use case to help us understand customer demand.
Metadata
Metadata
Assignees
Labels
completedThis item is complete and has been merged/shippedThis item is complete and has been merged/shippedidempotencyThis item relates to the Idempotency UtilityThis item relates to the Idempotency UtilityinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)testsPRs that add or change testsPRs that add or change tests
Type
Projects
Status
Shipped