Skip to content

Conversation

@am29d
Copy link
Contributor

@am29d am29d commented Feb 9, 2024

Description of your changes

Related issues, RFCs

In this PR, we

  • add top level permission contents read to make-version
  • pull up update_layer_arn_docs in to the layer deployment workflow
  • remove post release doc update job, because the docs will be automatically modified after we merge the PR with the latest layer ARNs.
  • add pull requests permission to layer deployment parent call

Issue number: #1799

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team February 9, 2024 15:44
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Feb 9, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Feb 9, 2024
@am29d am29d requested a review from dreamorosi February 9, 2024 15:44
@am29d am29d self-assigned this Feb 9, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@am29d am29d removed the request for review from a team February 9, 2024 15:52
@am29d am29d merged commit f9789e5 into main Feb 9, 2024
@am29d am29d deleted the chore/cleanup-doc-release-workflow branch February 9, 2024 15:53
@dreamorosi dreamorosi linked an issue Feb 9, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation This item relates to automation size/L PRs between 100-499 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: refactor release process

2 participants