Skip to content

fix: Remove publishing doc on develop version and fix missing leading 0 in version #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 28, 2021
Merged

fix: Remove publishing doc on develop version and fix missing leading 0 in version #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ffff59b
fix: delete on-docs-change.yml as it's duplicated with on-release.yml…
ijemmy Dec 28, 2021
0bbeb88
debug: echo release version to check why leading 0 is missing
ijemmy Dec 28, 2021
531d580
fix: change branch name
ijemmy Dec 28, 2021
f22ee5a
debug: find why leading 0 disappears in the RELEASE_VERSION
ijemmy Dec 28, 2021
a584740
debug: fix leading 0 disappears in the RELEASE_VERSION
ijemmy Dec 28, 2021
b07c2df
debug: test different syntx
ijemmy Dec 28, 2021
0aaa09a
debug: test different syntx2
ijemmy Dec 28, 2021
6e19254
debug: restor branch back to main
ijemmy Dec 28, 2021
cc192df
debug: restore publishing new version
ijemmy Dec 28, 2021
702f365
debug: restore publishing new version
ijemmy Dec 28, 2021
89904c7
debug: final check before creating PR
ijemmy Dec 28, 2021
febf608
debug: restore publishing new version + trigger on main branch
ijemmy Dec 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions .github/workflows/on-docs-change.yml
View file
Open in desktop

This file was deleted.

5 changes: 3 additions & 2 deletions .github/workflows/on-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Set RELEASE_VERSION env var
run: |
RELEASE_VERSION=$(cat packages/commons/package.json | jq '.version' -r)
echo "RELEASE_VERSION=${RELEASE_VERSION:1}" >> $GITHUB_ENV
echo "RELEASE_VERSION=${RELEASE_VERSION}" >> $GITHUB_ENV
- name: Install doc generation dependencies
run: |
pip install --upgrade pip
Expand All @@ -68,8 +68,9 @@ jobs:
- name: Build mkdocs site in "gh-pages" branch and push
run: |
rm -rf site
VERSION="$RELEASE_VERSION"
VERSION="${{ env.RELEASE_VERSION }}"
ALIAS="latest"
echo "Publishing doc for version: $VERSION"
mkdocs build
mike deploy --push --update-aliases "$VERSION" "$ALIAS"
# Set latest version as a default
Expand Down