Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Increase test timeout to fix flakiness #21

Merged
merged 1 commit into from May 22, 2019
Merged

Conversation

timrobotson
Copy link
Contributor

  • Increase the test timeout to 5000ms because sometimes SendLogsToCloudWatch isn't being called fast enough and so the tests fail.

Issue: Internal Ticket V117830572

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Increase the test timeout to 5000ms because sometimes
SendLogsToCloudWatch isn't being called fast enough and so the tests
fail.
@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   84.18%   84.18%           
=======================================
  Files          21       21           
  Lines        1018     1018           
=======================================
  Hits          857      857           
  Misses        161      161
Flag Coverage Δ
#ROS_1 84.18% <ø> (ø) ⬆️
#kinetic 84.17% <ø> (ø) ⬆️
#melodic 87.89% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cloudwatch_logs_common/test/log_publisher_test.cpp 76.04% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279b55d...9202f41. Read the comment docs.

@timrobotson timrobotson requested review from nburek and ross-desmond and removed request for mm318 May 21, 2019 20:10
@timrobotson timrobotson merged commit 68f3212 into master May 22, 2019
@timrobotson timrobotson deleted the increase-test-timeout branch May 22, 2019 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants