Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage cloudwatch logger #4

Merged

Conversation

Projects
None yet
2 participants
@juanrh
Copy link
Contributor

commented Jan 15, 2019

Issue #, if available:

Description of changes:
This changes enable adding unit tests to cloudwatchlogs-ros1 easily

  • Making the cloudwatch_logs_common a shared library allows to use it to build other libs. Otherwise we get an error /usr/bin/ld: /opt/workspace/install/cloudwatch_logs_common/lib/libcloudwatch_logs_common.a(log_manager_factory.cpp.o): relocation R_X86_64_32 against .rodata' can not be used when making a shared object; recompile with -fPIC` during build. Using a shared library for the common package was also done for other common packages like kinesisvideo-common

  • Making the factory method of LogManagerFactory virtual allows to replace it easily with a mock, and it's also consistent with LogManager and LogPublisher that already use virtual methods.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ross-desmond ross-desmond merged commit 64c377e into aws-robotics:master Jan 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.