Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes(#2196) #12

Merged
merged 2 commits into from Dec 27, 2018

Conversation

Projects
None yet
6 participants
@haverchuck
Copy link
Contributor

commented Dec 27, 2018

Issue #, if available:
Fixes #2196

Description of changes:
Adds proper unit test tooling and updates sample test.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Dustin Noyes and others added some commits Dec 27, 2018

@powerful23
Copy link
Contributor

left a comment

👍 LGTM!

@haverchuck haverchuck merged commit 3b51e19 into aws-samples:master Dec 27, 2018

"lint": "eslint --ext .js,.vue src test/unit/specs",
"build": "node build/build.js"
},
"dependencies": {
"@vue/cli-plugin-unit-jest": "^3.2.0",

This comment has been minimized.

Copy link
@elorzafe

elorzafe Dec 27, 2018

This should be devDependencies?

This comment has been minimized.

Copy link
@haverchuck

haverchuck Dec 27, 2018

Author Contributor

That's what I thought, but for some reason the vue cli put this in dependencies (and I followed their lead). I could probably change it, I just wanted to get this fix out quickly since the issue was stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.