Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

possibility of adding a CDK REPL to the workshop #426

Closed
2 tasks done
3p3r opened this issue Feb 7, 2022 · 7 comments
Closed
2 tasks done

possibility of adding a CDK REPL to the workshop #426

3p3r opened this issue Feb 7, 2022 · 7 comments
Labels
effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1

Comments

@3p3r
Copy link

3p3r commented Feb 7, 2022

General Information

  • I may be able to implement this feature request
  • This feature might incur a breaking change

Description

Hello! I am the author of cdk-web. I was wondering if adding a REPL-like feature to the workshop would be beneficial and wanted to gauge your interest.

If there's enough interest, I'll implement and open up a PR.

Proposed Solution

Using cdk-web to implement a REPL-like feature like the one here: https://3p3r.github.io/cdk-web/

CDK CLI Version

No response

Section

No response

Browser

No response

Language

No response

Other information

No response

@3p3r 3p3r added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 7, 2022
@mrpackethead
Copy link

This is a great idea. :-) My +1

@3p3r
Copy link
Author

3p3r commented Feb 10, 2022

I just updated the playground: https://3p3r.github.io/cdk-web/
This is very close to what a REPL would look like.

performance is OK-ish. my iPhone and my desktop can take it but I have a VM setup for work and it struggles in that.
there is also possibility of putting cdk web in a web worker to keep the page responsive.

@peterwoodworth peterwoodworth added effort/large Large work item – several weeks of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels May 27, 2022
@peterwoodworth
Copy link
Contributor

Something like this would be super cool if implemented well. If you're still interested in implementing this @3p3r, I'd love to see what you come up with

@3p3r
Copy link
Author

3p3r commented May 29, 2022

my offer is still on the table!

I am thinking, to create a shell like experience, we need to mix in XtermJS and something like Cash to provide basic commands like cd and grep and stuff like that.

I've already made this bridge: https://github.com/3p3r/cash-money

then it's just a matter of how do we style it for the website.

if I can sit down with maintainers of the workshop maybe for half an hour I think we can come up with something exciting.

@peterwoodworth
Copy link
Contributor

Wonderful to hear @3p3r !

I'll coordinate with the team once the work week begins and then reach out to you

@indrora
Copy link
Contributor

indrora commented Feb 13, 2023

@3p3r if you're interested in doing this as a community project, that'd be super awesome, but I don't think it'll fit well in the CDK Workshop.

@indrora indrora closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

No branches or pull requests

4 participants