Boost 1.81 #122
Boost 1.81 #122
Conversation
| set(Boost_USE_DEBUG_RUNTIME OFF) | ||
| #set_property(GLOBAL PROPERTY Boost_USE_MULTITHREADED ON) | ||
| set(BOOST_PKG_VERSION "1.79.0" CACHE STRING "") | ||
| find_package(Boost ${BOOST_PKG_VERSION} REQUIRED COMPONENTS system log log_setup thread program_options date_time filesystem) |
There was a problem hiding this comment.
you can use EXACT to enforce a specific version (default behavior is greater than or equal to specified version) : find_package(Boost ${BOOST_PKG_VERSION} EXACT REQUIRED COMPONENTS
Also, maybe add asio and http to the list of COMPONENTS, or do that later in another PR.
There was a problem hiding this comment.
It turns out asio and the other components we discussed with Marco are header only and can't be included here or it breaks.
Do we want EXACT here? Ideally we'd be as backwards & forwards compatible as possible.
There was a problem hiding this comment.
Previously we did not enforce an exact version, so when people tried building the local proxy with boost 1.81 while we were targeting 1.79, they got a build error instead of a cmake validation error
3 participants
Motivation
Modifications
Change summary
Testing
Built locally, ran unit tests, connected to tunnel.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.