Skip to content

fix(core): z116 aws config permissions #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 26, 2020
Merged

fix(core): z116 aws config permissions #359

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
682ce1d
fixed access denied issue
nachundu-amzn Aug 24, 2020
c1ab68b
added comment
nachundu-amzn Aug 24, 2020
d613d1d
fixed lint issues
nachundu-amzn Aug 24, 2020
1ffac43
Merge branch 'master' into fix/z116-AWS-Config-Permissions
nachundu-amzn Aug 26, 2020
353756a
added putBucket policy to the config role
nachundu-amzn Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/deployments/cdk/src/deployments/iam/step-1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,21 @@ export async function createConfigServiceRoles(props: IamConfigServiceRoleProps)
managedPolicies: [iam.ManagedPolicy.fromAwsManagedPolicyName('service-role/AWSConfigRole')],
});

/**
*
* As per the documentation, the config role should have
* the s3:PutObject permission to avoid access denied issues
* while AWS config tries to check the s3 bucket (in another account) write permissions
* https://docs.aws.amazon.com/config/latest/developerguide/s3-bucket-policy.html
*
*/
configRecorderRole.addToPrincipalPolicy(
new iam.PolicyStatement({
actions: ['s3:PutObject'],
resources: ['*'],
}),
);

new CfnIamRoleOutput(accountStack, `ConfigRecorderRoleOutput`, {
roleName: configRecorderRole.roleName,
roleArn: configRecorderRole.roleArn,
Expand Down