Skip to content

fix(core): z135 added wait for object exists in the account bucket #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2020
Merged

fix(core): z135 added wait for object exists in the account bucket #392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0aa90b2
added wait for object exists in the account bucket
nachundu-amzn Sep 16, 2020
1fb59a0
updated max attempts to 1 b/w delay of 5 seconds
nachundu-amzn Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/lib/custom-resources/cdk-s3-template/runtime/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,25 @@ async function onCreate(event: CloudFormationCustomResourceEvent) {
} catch (e) {
throw new Error(`Unable to put S3 object s3://${outputBucketName}/${outputPath}: ${e}`);
}

try {
// Waiting for the template available in s3
// default delay is 5 seconds and max retry attempts is 20
console.debug(`Waiting for ${outputBucketName}/${outputPath}`);
await throttlingBackOff(() =>
s3
.waitFor('objectExists', {
Bucket: outputBucketName,
Key: outputPath,
$waiter: {
maxAttempts: 1,
},
})
.promise(),
);
} catch (error) {
throw new Error(`Unable to find S3 object s3://${outputBucketName}/${outputPath}: ${error}`);
}
}

async function onUpdate(event: CloudFormationCustomResourceEvent) {
Expand Down