fix(core): PhZ-resolver-rules #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,36 @@ | |||
| # Security Hub Enable Standards | |||
Contributor
There was a problem hiding this comment.
update the documentation
| @@ -0,0 +1,36 @@ | |||
| # Security Hub Enable Standards | |||
Contributor
There was a problem hiding this comment.
update the documentation
src/lib/custom-resources/cdk-associate-hosted-zones/cdk/index.ts
Outdated
Show resolved
Hide resolved
src/lib/custom-resources/cdk-associate-hosted-zones/runtime/src/index.ts
Show resolved
Hide resolved
src/lib/custom-resources/cdk-associate-hosted-zones/runtime/src/index.ts
Show resolved
Hide resolved
src/lib/custom-resources/cdk-associate-resolver-rules/cdk/index.ts
Outdated
Show resolved
Hide resolved
| import { CfnStaticResourcesOutput } from './outputs'; | ||
|
|
||
| // Changing these values will lead to redeploying all Phase-4 RuleAssociation stacks | ||
| const MAX_RESOURCES_IN_STACK = 190; |
Contributor
There was a problem hiding this comment.
Is Resource per stack (190) for rule association correct? Could you please do a cross check
Contributor
Author
There was a problem hiding this comment.
yeah we only need one resource per associating all rules to VPC
Comment on lines
385
to
+390
| function domainToName(domain: string): string { | ||
| return domain.replace(/\./gi, '-'); | ||
| } | ||
|
|
||
| export function createRuleName(name: string): string { | ||
| const hash = hashPath([name], 8); |
Contributor
There was a problem hiding this comment.
Move these 2 functions to common package so that in future, we can reuse them in other modules
nachundu-amzn
approved these changes
Sep 18, 2020
naveenkoppula
deleted the
fix/Make-VPC-Related-Deployment-in-Same-Stack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.