fix(core): Regional Interface Endpoints #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
111
to
112
| for (const region of regions) { | ||
| const sts = new STS(); |
Contributor
There was a problem hiding this comment.
Suggested change
| for (const region of regions) { | |
| const sts = new STS(); | |
| const sts = new STS(); | |
| for (const region of regions) { |
Comment on lines
231
to
234
| if (e.code === 'VPCAssociationNotFound') { | ||
| console.warn(`The specified VPC "${vpcId}" and hosted zone "${hostedZoneId}" are not currently associated.`); | ||
| } else if (e.code === 'NoSuchHostedZone') { | ||
| console.warn(`The specified VPC "${vpcId}" and hosted zone "${hostedZoneId}" are not currently associated.`); |
Contributor
There was a problem hiding this comment.
Suggested change
| if (e.code === 'VPCAssociationNotFound') { | |
| console.warn(`The specified VPC "${vpcId}" and hosted zone "${hostedZoneId}" are not currently associated.`); | |
| } else if (e.code === 'NoSuchHostedZone') { | |
| console.warn(`The specified VPC "${vpcId}" and hosted zone "${hostedZoneId}" are not currently associated.`); | |
| if (e.code === 'VPCAssociationNotFound' || e.code === 'NoSuchHostedZone') { | |
| console.warn(`The specified VPC "${vpcId}" and hosted zone "${hostedZoneId}" are not currently associated.`); | |
| } |
Comment on lines
248
to
252
| if (e.code === 'VPCAssociationNotFound') { | ||
| console.warn(`The specified VPC "${vpcId}" and hosted zone "${hostedZoneId}" are not currently associated.`); | ||
| } else if (e.code === 'NoSuchHostedZone') { | ||
| console.warn(`The specified VPC "${vpcId}" and hosted zone "${hostedZoneId}" are not currently associated.`); | ||
| } else { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (e.code === 'VPCAssociationNotFound') { | |
| console.warn(`The specified VPC "${vpcId}" and hosted zone "${hostedZoneId}" are not currently associated.`); | |
| } else if (e.code === 'NoSuchHostedZone') { | |
| console.warn(`The specified VPC "${vpcId}" and hosted zone "${hostedZoneId}" are not currently associated.`); | |
| } else { | |
| if (e.code === 'VPCAssociationNotFound' || e.code === 'NoSuchHostedZone') { | |
| console.warn(`The specified VPC "${vpcId}" and hosted zone "${hostedZoneId}" are not currently associated.`); | |
| } else { |
src/lib/custom-resources/cdk-create-hosted-zone/runtime/src/index.ts
Outdated
Show resolved
Hide resolved
src/lib/custom-resources/cdk-create-hosted-zone/runtime/src/index.ts
Outdated
Show resolved
Hide resolved
nachundu-amzn
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.