Feat: Added flexibility to super-easy deployment mode #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
statefb
reviewed
May 20, 2024
statefb
reviewed
May 27, 2024
statefb
reviewed
May 27, 2024
cdk/test/cdk.test.ts
Outdated
| @@ -29,6 +29,7 @@ describe("Fine-grained Assertions Test", () => { | |||
| start: {}, | |||
| }, | |||
| enableMistral: false, | |||
| selfSignUpEnabled: true, | |||
statefb
reviewed
May 27, 2024
cdk/test/cdk.test.ts
Outdated
| @@ -84,6 +85,7 @@ describe("Fine-grained Assertions Test", () => { | |||
| start: {}, | |||
| }, | |||
| enableMistral: false, | |||
| selfSignUpEnabled: true, | |||
| @@ -34,8 +35,8 @@ export class Auth extends Construct { | |||
| requireDigits: true, | |||
| minLength: 8, | |||
| }, | |||
| // Disable if identity providers are configured | |||
| selfSignUpEnabled: !props.idp.isExist(), | |||
| // Disable id selfSignUpEnabled is given as false or if selfSignUpEnabled is true and idp is provided | |||
There was a problem hiding this comment.
今更で申し訳ないのですが、この変更にはどのような意味があるのでしょうか？
外部idpを使用している場合でも、自己登録をONにしたい需要はあると思うのと、これで制限されているのがどこかに明文化されているのでしょうか？
よく分からない仕様になってしまわないかな？と思っていたりするのですが。
普通にREADMEに記載されていました。すみません。
外部 ID プロバイダーを構成すると、値は無視され、自動的に無効になります。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
New Features
Benefits
By leveraging these new parameters, you can tailor the deployment to better meet your security requirements and operational needs.