Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

Conversation

@mtfranchetto
Copy link
Contributor

Description

Fixes the PerUnitStorageThroughput on Lustre FSx not being added to the final cluster configuration, starting from an empty template.
Closes #274.

Changes

  • put PerUnitStorageThroughput in the configuration when a FSx Lustre is created
  • extracted PerUnitStorageThroughput default values into their own constants

Changelog entry

  • Fixes PerUnitStorageThroughput on Lustre FSx not being added to the final cluster configuration

How Has This Been Tested?

  • Started a new wizard, adding a FSx Lustre filesystem: the PerUnitStorageThroughput parameter is added to the configuration
  • When changing the value of PerUnitStorageThroughput it is reflected in the configuration

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used our i18n solution instead (see here)
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mtfranchetto mtfranchetto requested a review from mendaomn October 31, 2022 14:27
@mtfranchetto mtfranchetto requested a review from mendaomn October 31, 2022 15:10
@mtfranchetto mtfranchetto merged commit ec83135 into main Oct 31, 2022
@mtfranchetto mtfranchetto deleted the fix-per-unit-storage-throughput branch October 31, 2022 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parallelCluster Manager 3.2.0 failed on PERSISTENT_2 Lustre creation

2 participants