Skip to content

Conversation

@ragibmahsan
Copy link
Contributor

@ragibmahsan ragibmahsan commented Dec 30, 2024

Issue #, if available: #2574

Description of changes: New pattern submission for Okta System Log Events to Lambda and CloudWatch

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ellisms
Copy link
Contributor

ellisms commented Jan 23, 2025

Hi @ragibmahsan Thanks for the submission. Before I start reviewing, I'd like to make a directory structure change since I foresee additional SaaS integrations being created.
Can you update the PR to include the following directory structure (from root):
/eventbridge-partner-sources/1-okta/cdk-python/<your files>

Goal is to model this after the eventbridge-api-destinations directory: https://github.com/aws-samples/serverless-patterns/tree/main/eventbridge-api-destinations

@ragibmahsan
Copy link
Contributor Author

I updated the structure

Copy link
Contributor

@ellisms ellisms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ragibmahsan, requesting a few changes after review.

@ragibmahsan ragibmahsan requested a review from ellisms February 3, 2025 15:18
@julianwood julianwood merged commit 81cee2f into aws-samples:main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants