Skip to content

Conversation

@MakendranG
Copy link
Contributor

Issue #, if available:

Description of changes:

Have corrected the spelling of validation and also curl command.

With the previous curl command, it is not getting output. The curl command which I pasted, it works.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Have corrected the spelling of validation and also curl command.

With the previous curl command, it is not getting output. The curl command which I pasted, it works.
@ellisms
Copy link
Contributor

ellisms commented Jan 16, 2025

Hi @MakendranG , Thanks for catching this error. I don't think the use of id or the order query string makes much sense in this pattern and it must have been inadvertently added at some point. Instead of publishing the updated test commands, I'd like to suggest updating the pattern to remove those unnecessary parameters. Would you be willing to make those changes?

@ellisms
Copy link
Contributor

ellisms commented Feb 14, 2025

Hi @MakendranG - checking in on this PR. Are you able to make my suggested change?

@MakendranG
Copy link
Contributor Author

Hello @ellisms

I have updated the pattern to simplify and focus on the core data validation functionality.

Let me know if any further adjustments are needed.

Copy link
Contributor

@ellisms ellisms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MakendranG . Requesting 2 minor changes.

MakendranG and others added 2 commits February 27, 2025 20:55
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
@MakendranG MakendranG requested a review from ellisms February 27, 2025 15:26
@ellisms ellisms merged commit 78af068 into aws-samples:main Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants