From dede02b39c4e0fdb1e9f690c67a5b686e434040f Mon Sep 17 00:00:00 2001 From: indranil-banerjee-aws Date: Wed, 15 Jan 2025 11:57:03 -0800 Subject: [PATCH 1/2] Fixed msk-lambda-iam-java-sam.json file. Removed reference to non-functional cloudformation template --- msk-lambda-iam-java-sam/msk-lambda-iam-java-sam.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/msk-lambda-iam-java-sam/msk-lambda-iam-java-sam.json b/msk-lambda-iam-java-sam/msk-lambda-iam-java-sam.json index b9394bbb1..8b4f708ac 100644 --- a/msk-lambda-iam-java-sam/msk-lambda-iam-java-sam.json +++ b/msk-lambda-iam-java-sam/msk-lambda-iam-java-sam.json @@ -8,8 +8,7 @@ "headline": "How it works", "text": [ "This pattern provides a Lambda function along with an Event Source Mapping to a Kafka topic.", - "It requires that you already have an Amazon Managed Streaming for Kafka (Amazon MSK) cluster setup with a topic created. ", - "If you don't already have an MSK cluster, you can use the example in this pattern https://serverlessland.com/patterns/msk-cfn-sasl-lambda (linked in the resources) to deploy a cluster.", + "It provides a Cloudformation template that creates an Amazon Managed Streaming for Kafka (Amazon MSK) cluster.", "This pattern works with either a Provisioned or Serverless MSK cluster as long as the cluster is configured to use IAM authentication. ", "For detailed deployment instructions instructions see the README." ] From fa51ccc84c9ceefc7dda5411537d2b5e9c3eaf79 Mon Sep 17 00:00:00 2001 From: indranil-banerjee-aws Date: Thu, 30 Jan 2025 23:46:21 -0800 Subject: [PATCH 2/2] Fixed msk-lambda-iam-java-sam/example-pattern.json file and also added a note in the README.md about handling an existing MSK cluster --- msk-lambda-iam-java-sam/README.md | 2 ++ msk-lambda-iam-java-sam/example-pattern.json | 8 ++------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/msk-lambda-iam-java-sam/README.md b/msk-lambda-iam-java-sam/README.md index c7a93085d..88597919f 100644 --- a/msk-lambda-iam-java-sam/README.md +++ b/msk-lambda-iam-java-sam/README.md @@ -155,6 +155,8 @@ The sam deploy command will package and deploy your application to AWS, with a s * **SAM configuration environment [default]**: Environment for storing deployment information locally You should get a message "Successfully created/updated stack - in " if all goes well + +**Note: In case you want to deploy the Lambda function by pointing to an existing MSK Cluster and not the one created by running the CloudFormation template provided in this pattern, you will need to modify the values of the parameters MSKClusterName and MSKClusterId accordingly** ## Test the sample application diff --git a/msk-lambda-iam-java-sam/example-pattern.json b/msk-lambda-iam-java-sam/example-pattern.json index 571060cb0..9e7c4dd38 100644 --- a/msk-lambda-iam-java-sam/example-pattern.json +++ b/msk-lambda-iam-java-sam/example-pattern.json @@ -8,8 +8,8 @@ "headline": "How it works", "text": [ "This pattern provides a Lambda function along with an Event Source Mapping to a Kafka topic.", - "It requires that you already have an Amazon Managed Streaming for Kafka (Amazon MSK) cluster setup with a topic created. ", - "If you don't already have an MSK cluster, you can use the example in this pattern https://serverlessland.com/patterns/msk-cfn-sasl-lambda (linked in the resources) to deploy a cluster.", + "The Lambda function requires that you already have an Amazon Managed Streaming for Kafka (Amazon MSK) cluster setup with a Kafka topic created. ", + "In this pattern, an AWS CloudFormation template is provided, that installs an Amazon MSK cluster and also creates a Kafka topic.", "This pattern works with either a Provisioned or Serverless MSK cluster as long as the cluster is configured to use IAM authentication. ", "For detailed deployment instructions instructions see the README." ] @@ -24,10 +24,6 @@ }, "resources": { "bullets": [ - { - "text": "Amazon MSK cluster pattern", - "link": "https://serverlessland.com/patterns/msk-cfn-sasl-lambda" - }, { "text": "Using AWS Lambda with Amazon MSK", "link": "https://docs.aws.amazon.com/lambda/latest/dg/with-msk.html"