Added runbook for SC IAM 22 #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmekari
requested review from
a team,
CrypticCabub,
G-Lenz,
dougtoppin,
gsingh04,
hearde and
schana
| return new RevokeUnusedIAMUserCredentialsDocument(stage, id, { | ||
| ...props, | ||
| controlId: 'IAM.22', | ||
| parameterToPass: '45', |
Member
There was a problem hiding this comment.
could this be named something more descriptive? I'm not entirely sure the purpose of the remediation but maybe something like "LifetimeDaysExceeding"?
Contributor
There was a problem hiding this comment.
In this instance it makes sense for there to be a generic name because this props struct is used by different remediations. There's probably a more elegant way of specifying something like this, where the implementation only varies by a value or two across different controls/standards, but that's not an abstraction that this was originally designed for.
hearde
approved these changes
Mar 14, 2023
G-Lenz
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added runbook for SC IAM 22. This is similar to IAM 8 so I am using the same remediation. Because of the 45 day requirement for this remediation, it needs its own runbook so I can pass that parameter along.
Deploys successfully, passes all unit tests, tested by @hearde and successful.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.