Adding all endpoint types to SNS.2 Remediation #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmekari
requested review from
a team,
CrypticCabub,
G-Lenz,
dougtoppin,
gsingh04,
hearde and
schana
CrypticCabub
approved these changes
Mar 14, 2023
hearde
reviewed
Mar 16, 2023
| "SuccessSampleRate": logging_arn } | ||
| "LambdaFailureFeedbackRoleArn": logging_arn, | ||
| "LambdaSuccessFeedbackRoleArn": logging_arn, | ||
| "LambdaSuccessFeedbackSampleRate": logging_arn, |
Contributor
There was a problem hiding this comment.
Should the expected sample rate really be the logging arn?
Contributor
Author
There was a problem hiding this comment.
No and it scares me that it just passes like that...
|
|
||
| for endpoint in endpointTypes: | ||
| sns.set_topic_attributes(TopicArn=topic_arn, AttributeName=f'{endpoint}SuccessFeedbackRoleArn', AttributeValue='') | ||
| sns.set_topic_attributes(TopicArn=topic_arn, AttributeName=f'{endpoint}FailureFeedbackRoleArn', AttributeValue='') |
Contributor
There was a problem hiding this comment.
could probably use error handling here - if we're trying to reset, we should catch exceptions on each iteration, log, and continue
| sns.set_topic_attributes(TopicArn=topic_arn, AttributeName=failureFeedbackRoleValue, AttributeValue=logging_role) | ||
| for endpoint in endpointTypes: | ||
| sns.set_topic_attributes(TopicArn=topic_arn, AttributeName=f'{endpoint}SuccessFeedbackRoleArn', AttributeValue=logging_role) | ||
| sns.set_topic_attributes(TopicArn=topic_arn, AttributeName=f'{endpoint}FailureFeedbackRoleArn', AttributeValue=logging_role) |
Contributor
There was a problem hiding this comment.
I agree with your choice of error handling here - the change is transactional as a whole, it either fully succeeds or we try to reset to the best of our ability
hearde
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding all endpoint types to SNS.2 Remediation, rather than just Lambda. Edited unit testing to reflect this.
Passes all unit tests, deploys successfully, tested and works as expected.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.