Skip to content
This repository was archived by the owner on Oct 25, 2023. It is now read-only.

Conversation

@pierreaws
Copy link
Contributor

Issue #, if available:

Some pdfs were causing an error to be thrown from the lambda jobresultprocessor.

Description of changes:

A add() method was erroneously being invoked on a python list, this was replaced with a append()

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

comprehendAndMedicalEntities[key] = val
else:
comprehendAndMedicalEntities[key].add(val)
comprehendAndMedicalEntities[key].append(val)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should perhaps make this change in SyncProcessor lambda as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

replacing the erroneous invocation of add() on a list by append()
Copy link
Contributor

@ShivaniMehendarge ShivaniMehendarge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@alexchirayath alexchirayath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexchirayath alexchirayath merged commit 7465111 into master Feb 11, 2021
alexchirayath pushed a commit that referenced this pull request Feb 11, 2021
@alexchirayath alexchirayath mentioned this pull request Feb 11, 2021
@alexchirayath alexchirayath deleted the list_bug branch September 15, 2021 06:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants