This repository was archived by the owner on Oct 25, 2023. It is now read-only.
Encrypt sqs sns #90
Merged
Encrypt sqs sns #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 29, 2020 20:01
This reverts commit a4620a4.
…understanding-solution
…understanding-solution
…understanding-solution
…understanding-solution
…understanding-solution
…understanding-solution into encrypt-sqs-sns
GWP
requested review from
CLBray,
ShivaniMehendarge,
alexchirayath and
pierreaws
alexchirayath
approved these changes
Aug 7, 2020
Contributor
alexchirayath
left a comment
alexchirayath
left a comment
There was a problem hiding this comment.
LGTM
Please make the changes on to kendraMaster as well
Moving forward (in a few weeks), kendraMaster will be the default branch will be maintained
pierreaws
approved these changes
Aug 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Job Results queue and Job Competion Topic need to have server side encryption
Description of changes:
Added encryption to the CDK stack
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.