chore: remove dead tag command#1273
Merged
Merged
Conversation
The tag command (add/remove/list/set-default) was fully implemented but never wired into the CLI. Tags are managed directly via agentcore.json config, making this code unreachable.
github-actions
Bot
added
the
agentcore-harness-reviewing
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-1273-tarball/aws-agentcore-0.13.1.tgz |
tejaskash
approved these changes
May 15, 2026
agentcore-cli-automation
approved these changes
May 15, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM. Clean delete-only change. Verified:
- No remaining references to
commands/tag/,tag/action,tag/types, or the exported functions (addTag,removeTag,listTags,setDefaultTag,removeDefaultTag) anywhere undersrc/,docs/, orinteg-tests/. - The CLI wiring (
command.tsx+index.ts) was already removed back in the revert PR #612;action.ts/types.ts/the test were re-introduced by PR #643 but never re-wired, so they have been orphaned ever since. This PR finishes that cleanup. - No telemetry / mocking concerns since this is purely deletion of unreachable code.
github-actions
Bot
removed
the
agentcore-harness-reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/cli/commands/tag/directory (action.ts, types.ts, tests)agentcore.jsonconfig instead of dedicated CLI commandsTest plan
tsc --noEmitpasses with no errorscommands/tag/anywhere in the codebase