fix: resolve create harness Dockerfile paths from command cwd#1474
Open
kiwigitops wants to merge 1 commit into
Open
fix: resolve create harness Dockerfile paths from command cwd#1474kiwigitops wants to merge 1 commit into
kiwigitops wants to merge 1 commit into
Conversation
notgitika
approved these changes
Jun 8, 2026
notgitika
left a comment
notgitika
left a comment
Contributor
There was a problem hiding this comment.
LGTM thanks for the clean fix!
| apiKeyArn: options.apiKeyArn, | ||
| containerUri: containerOption.containerUri, | ||
| dockerfilePath: containerOption.dockerfilePath, | ||
| dockerfileBaseDir: commandCwd, |
Contributor
There was a problem hiding this comment.
nit: might be worth a brief comment here noting that dockerfileBaseDir intentionally uses CWD (not outputDir) since the Dockerfile is a source input.
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
agentcore createadds a harness with a Dockerfile, the project directory is created before the harness is added. Relative Dockerfile paths were resolved from that new project root, so a path supplied from the directory whereagentcore createwas invoked could fail.This threads the create command's original working directory into the harness add path and uses it as the base for relative Dockerfile paths. Existing harness add behavior still falls back to the project root.
Related Issue
Closes #1128
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsAdditional checks:
npx vitest run --project unit src/cli/primitives/__tests__/HarnessPrimitive.test.tsagentcore create --container ./Dockerfile.custom, verifying the Dockerfile is copied into the generated harness directory and recorded inharness.jsonChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.