[Bug fix] Do not sample right after flushing profile #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2021 15:09
There was a bug introduced from Issue #15 where we attempt to sample right after flushing profiles even is_profiling_in_progress has been reset to False already
| profiler.stop() | ||
|
|
||
| assert wrapped_add.call_count >= 3 | ||
| # We should see at least 2 sample in 4 seconds as the sequence should happen in the order of |
test/unit/test_profiler_runner.py
Outdated
| self.profiler_runner._profiling_command() | ||
| self.mock_collector.refresh_configuration.assert_called_once() | ||
|
|
||
| def test_when_it_does_not_sample_when_it_reports(self): |
Contributor
There was a problem hiding this comment.
I think it should be renamed to "when_it_reports_it_does_not_sample"?
test/unit/test_profiler_runner.py
Outdated
| def test_when_it_does_not_sample_when_it_reports(self): | ||
| self.is_time_to_report = True | ||
|
|
||
| assert(self.profiler_runner._profiling_command()) |
Contributor
There was a problem hiding this comment.
Minor: no parenthesis.
mirelap-amazon
suggested changes
Mar 2, 2021
Contributor
mirelap-amazon
left a comment
mirelap-amazon
left a comment
There was a problem hiding this comment.
Minor comments, please see below.
mirelap-amazon
approved these changes
Mar 2, 2021
mirelap-amazon
assigned
gimki and
mirelap-amazon and unassigned
gimki and
mirelap-amazon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug introduced from Issue #15 where we attempt to sample
right after flushing profiles even is_profiling_in_progress has been
reset to False already
Issue #, if available:
#15
Description of changes:
We would not attempt to sample after flushing the profile given that we have also set is_profiling_in_progress to False already.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.