Add errors metadata in agent debug info with granular sdk client error metrics #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r metrics
Also, adding metrics which tells us how many of RFN exception will
try to create profiling group. ErrorsMetadata is part of
AgentDebugInfo which is part of the Profile. So, everytime we submit
a profile we submit these metrics along with it.
SdkClientErrors will tell us total failures happening because of API
calls. Individual API call failures are captured with the same name
as APIs and the rfne resulting in auto creation of PG is also
captured.
pandpara
requested review from
gimki and
mirelap-amazon
and removed request for
gimki
PapaPedro
reviewed
Apr 22, 2021
Added comments for more clarity.
PapaPedro
reviewed
Apr 26, 2021
PapaPedro
reviewed
Apr 26, 2021
Contributor
PapaPedro
left a comment
PapaPedro
left a comment
There was a problem hiding this comment.
Looks good to me, please fix the failing unit test
… doesn't affect datetime value
PapaPedro
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add errors metadata in agent debug info with granular sdk client error metrics
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.