Add synthetic frame for queue.get(block=True)
#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever some python code is waiting for an item to arrive in a queue, the current flame grpah will only show the function where the queue.get is called, the rest of the stack is not showing. This is unfortunate because we would need to remap those stacks into WAITING state. This change adds another synthetic frame for this specific frame when the source code at the end of the sampled stack has `.get(block=True` This looks like it could trigger a lot of false positives but it will only happen when this is the leaf of the stack so we would need this code to call some native code that does not appear in the stack but where we spend a lot of time.
mirelap-amazon
approved these changes
Apr 30, 2021
mirelap-amazon
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever some python code is waiting for an item to arrive in a queue,
the current flame grpah will only show the function where the queue.get
is called, the rest of the stack is not showing. This is unfortunate
because we would need to remap those stacks into WAITING state.
This change adds another synthetic frame for this specific frame when
the source code at the end of the sampled stack has
.get(block=TrueThis looks like it could trigger a lot of false positives but it will
only happen when this is the leaf of the stack so we would need this
code to call some native code that does not appear in the stack but
where we spend a lot of time.